Support go's coverage format #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support parsing go's coverage format, effectively converting their "Statement Range" coverage into Line Coverage. Branch Coverage isn't available. This was hand verified against a larger go report by directly comparing go's html to the grcov generated HTML.
marco-c
reviewed
May 15, 2025
| pub fn parse_gocov<T: Read>( | ||
| reader: &mut BufReader<T>, | ||
| ) -> Result<Vec<(String, CovResult)>, ParserError> { | ||
| let re = Regex::new(r"([^:]+):(\d+)\.\d+,(\d+)\.\d+ (\d+) (\d+)").unwrap(); |
There was a problem hiding this comment.
nit: we could compile this only once by saving it in a static variable (can be a follow-up)
|
I'll do a follow up soon as the current implementation assumes a file
doesn't repeat, but in practice, they do.
…On Thu, May 15, 2025 at 2:43 PM Marco Castelluccio ***@***.***> wrote:
Merged #1339 <#1339> into master.
—
Reply to this email directly, view it on GitHub
<#1339 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGB4ZV6JBWOFGFAFRCW72L26UDBJAVCNFSM6AAAAAB4EFZEO2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGY3TSNJXHAYTQMI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing go's coverage format, effectively converting their "Statement Range" coverage into Line Coverage. Branch Coverage isn't available.
This was hand verified against a larger go report by directly comparing go's html to the grcov generated HTML.